Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pixels per NDB #66

Open
cswales opened this issue Nov 11, 2022 · 4 comments
Open

More pixels per NDB #66

cswales opened this issue Nov 11, 2022 · 4 comments
Labels
3 LowPriority - chromatik A reminder to do it

Comments

@cswales
Copy link
Collaborator

cswales commented Nov 11, 2022

Not critical -
Could assign more pixels per ndb in the fixture files by setting up two outputs that happened to point to the same ip address. Apparently this is totally legal.
(Would be pretty easy to test manually on site, by just replacing one ip address with a copy of another one)

@mcslee
Copy link
Collaborator

mcslee commented Nov 11, 2022

Confirming that output packets with the DDP protocol are structured as-defined in LXF files. LX will not attempt to do any merging or splicing of DDP.

If you say: output: { protocol: "ddp", start: 0, num: 10000, ... } it's going to make a 10000-pixel packet (this will not go well!)

If you say:

outputs: [
  { protocol: "ddp", start: 0, num: 10, ... },
  { protocol: "ddp", start: 10, num: 10, ... },
  { protocol: "ddp", start: 20, num: 10, ... },
  ...
]

Then you're going to get a lot of 10-pixel packets. Should work fine but probably not the best idea.

Point is - it is completely up to you guys to format your output definitions to whatever level of grouping and packet size you prefer.

@cswales
Copy link
Collaborator Author

cswales commented Nov 12, 2022

Yes, I think the idea was to have more than one packet per NDB. I think the packet size right now is limited by the UDP packet size on the wire, and right now we're limiting ourselves to just one packet, which is considerably less than the NDB is capable of. Tagging @bbulkow for verification

@bbulkow bbulkow added the 2 MediumPriority - chromatik nice to fix but can go live without it label Nov 13, 2022
@bbulkow
Copy link
Collaborator

bbulkow commented Nov 13, 2022

Realistically, we already have all the NDBs we need in the trees, and this isn't a big deal. It's a small deal though, because with this, we can map cubes anywhere instead of having to think through where the 1500 byte breaks happen.

And for anyone looking at this later, it's really hard to get a raspberry pi to output > 1500 frames.

@bbulkow bbulkow added 3 LowPriority - chromatik A reminder to do it and removed 2 MediumPriority - chromatik nice to fix but can go live without it labels Nov 13, 2022
@bbulkow
Copy link
Collaborator

bbulkow commented Nov 19, 2022

This was recoded, and so it is likely that a given NDB will be turned into multiple outputs, but there is no attempt to limit an output. This code can now be changed likely pretty easily to limit. The limit should be (1500 - 10) / 3 RGB, because I think DDP has a 10 byte header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 LowPriority - chromatik A reminder to do it
Projects
None yet
Development

No branches or pull requests

3 participants