Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addObserver not passing optional 'context' object to callback #31

Open
matygo opened this issue Sep 17, 2010 · 3 comments
Open

addObserver not passing optional 'context' object to callback #31

matygo opened this issue Sep 17, 2010 · 3 comments

Comments

@matygo
Copy link

matygo commented Sep 17, 2010

I created a test case here: http://gist.github.com/585048 to demonstrate the issue.

Basically passing a 'context' object to addObserver does not seem to get passed on to the callback,
the 'non context' signature (e.g. fooDidChange: function(sender, key, value, rev); ) is being called even if a context is passed (and should be calling this signature: fooDidChange: function(sender, key, value, context, rev); )

@wagenet
Copy link
Contributor

wagenet commented Sep 18, 2010

What version is this for? 1.4 or quilmes? Also, has this worked for you in the past?

@paulitex
Copy link

quilmes. I'm not sure if it worked in the past, didn't encounter it. Can someone verify that the tests fails for them as well?

@wagenet
Copy link
Contributor

wagenet commented Sep 18, 2010

Test appears to fail in master/1.4. However, unless it's a regression it won't be fixed for 1.4. It's on the radar for 1.5 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants