Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy server strips port from location in header responses #2

Open
alexgb opened this issue Oct 29, 2009 · 2 comments
Open

Proxy server strips port from location in header responses #2

alexgb opened this issue Oct 29, 2009 · 2 comments

Comments

@alexgb
Copy link

alexgb commented Oct 29, 2009

Seems that line 90 in proxy.rb should reinsert the environments port in the location header.

value.gsub!(/^http://#{http_host}(:[0-9]+)?//, "http://#{http_host}:4020/") if key.downcase == 'location'

Otherwise 204 redirects won't work with virtual hosts

@sproutit
Copy link
Collaborator

sproutit commented Nov 2, 2009

anyway we can get a patch for this w/ some unit test love?

@wagenet
Copy link
Contributor

wagenet commented Sep 15, 2010

This may still be an issue. The current line is: value.gsub!(/^http:\/\/#{http_host}(:[0-9]+)?\//, "http://#{http_host}/") if key.downcase == 'location' I'm not sure what the exact point of it is so I'm hesitant to mess with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants