Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image loading should trigger automatic height recalc. #9

Open
dcporter opened this issue Jun 3, 2014 · 0 comments
Open

Image loading should trigger automatic height recalc. #9

dcporter opened this issue Jun 3, 2014 · 0 comments

Comments

@dcporter
Copy link
Member

dcporter commented Jun 3, 2014

EditorView's value update process triggers a recurring timer which automatically recalculates the height at regular and decreasing intervals. This handles the situation where a slow-loading image pops in after a while and changes the height of things without any change registering to the value.

Instead of this blunt approach, we ought to be able to check the DOM for image elements and attach load listeners to trigger a height recalc only and automatically when the image loads.

@dcporter dcporter changed the title Slow-loading images are (likely) causing height issues. Image loading should trigger automatic height recalc. Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant