Units test to investigate AMQP generation #790
Conversation
✅ Deploy Preview for springwolf-ui canceled.
|
| @@ -24,6 +24,7 @@ springwolf-bindings/springwolf-sqs-binding/build/ | |||
| node_modules/ | |||
|
|
|||
| asyncapi.actual.json | |||
| asyncapi.actual.yaml | |||
There was a problem hiding this comment.
Add YAML to ease analysis / investigation
| import lombok.NoArgsConstructor; | ||
|
|
||
| @NoArgsConstructor(access = AccessLevel.PRIVATE) | ||
| public final class AmqpConstants { |
There was a problem hiding this comment.
Add constant to ease navigation in code
| @Exchange( | ||
| name = AmqpConstants.EXCHANGE_CRUD_TOPIC_EXCHANGE_1, | ||
| type = ExchangeTypes.TOPIC), | ||
| key = AmqpConstants.ROUTING_KEY_ALL_MESSAGES, |
There was a problem hiding this comment.
using "#" routing key
| host: amqp:5672 | ||
| protocol: amqp | ||
| channels: | ||
| 'CRUD-topic-exchange-1_#': |
There was a problem hiding this comment.
in generated ayncapi.yaml, this is replaced by "#" and there are 2 messages (GenericPayloadDto and ExamplePayLoadDto) which are associated both associated to CRUD-topic-exchange-1 !
And NOT to CRUD-topic-exchange-2 !
I would have expected to have 2 separated channels, as written in this file (on for exchange CRUD-topic-exchange-1, the other for exchange CRUD-topic-exchange-2)
Something is fishy here.
|
Hi @pdalfarr, I agree with your point on the expected channel name. Also, it would be great if you can verify the comments on RabbitListenerUtil as I gather them by testing, but have low confidence since I haven't used RabbitMQ in production (see https://github.com/springwolf/springwolf-core/pull/886/files#r1699142615 ) |
|
Closing this PR, as the proposed changes have been merged via other PRs. Also, part of the issue has been addressed, while the link from exchange to queue is missing in the AsyncAPI at this point. Lets move the discussion into the original Springwolf issue #366 |
Units test to investigate AMQP generation
I added some comments in the PR.