Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven spring (boot) versions are invalid '<version>.</version>' #1086

Open
piewie opened this issue Nov 20, 2024 · 4 comments
Open

Maven spring (boot) versions are invalid '<version>.</version>' #1086

piewie opened this issue Nov 20, 2024 · 4 comments
Labels
bug Something isn't working staged for release

Comments

@piewie
Copy link

piewie commented Nov 20, 2024

Describe the bug
Since 1.8.0 maven pom does not longer has a version for spring (and spring boot) dependencies, see https://repo1.maven.org/maven2/io/github/springwolf/springwolf-core/1.8.0/springwolf-core-1.8.0.pom

Since there is no version specified in either the dependency management nor parent, this results in an error (classes missing or semver compatibility issues). (solution now is exclude them all and specify add the dependencies ourselves)

Dependencies and versions used
1.8.0

Code example
If possible, an example project or snippet that reproduces the bug.

Stack trace and error logs
If an exception has been thrown or an error was logged by springwolf.

example semver
Some nested dependencies use another major version for org.springframework:spring-messaging:6.1.13
paths to dependency are:
+-xx
+-yy
+-io.github.springwolf:springwolf-core:1.8.0 (managed) <-- io.github.springwolf:springwolf-core:1.8.0
+-org.springframework:spring-messaging:6.1.13 [runtime] (managed) <-- org.springframework:spring-messaging:. [runtime]

@piewie piewie added the bug Something isn't working label Nov 20, 2024
@timonback
Copy link
Member

Thank you for the report @piewie!
This is related to the switch to gradle version catalog, which had unforeseen failures for the maven pom files.

I merged #1088 to address it and the spring boot dependencies do not have a version anymore (in 1.8.0 they used .).

Pom files for springwolf-core related to the merge of the PR #1088:
before: https://s01.oss.sonatype.org/content/repositories/snapshots/io/github/springwolf/springwolf-core/1.9.0-SNAPSHOT/springwolf-core-1.9.0-20241118.163136-30.pom
After: https://s01.oss.sonatype.org/content/repositories/snapshots/io/github/springwolf/springwolf-core/1.9.0-SNAPSHOT/springwolf-core-1.9.0-20241120.190409-31.pom

Can you verify the 1.9.0-SNAPSHOT version to confirm it is working for you again?

Copy link

The change is staged for release and will be part of the next release.

If you want to try and verify it in your application today,
use the latest 1.X.0-SNAPSHOT build as described in our README.md > Testing SNAPSHOT version

Thank you for the report/contribution!

@piewie
Copy link
Author

piewie commented Nov 21, 2024

@timonback according to my colleague it's fixed indeed, thx for the quick work.
What's your release schedule, each month?

@timonback
Copy link
Member

Yes, we plan for Friday next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working staged for release
Projects
None yet
Development

No branches or pull requests

2 participants