Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2dbc] Support ClickHouseDialect #1947

Closed
eddumelendez opened this issue Nov 22, 2024 · 1 comment
Closed

[r2dbc] Support ClickHouseDialect #1947

eddumelendez opened this issue Nov 22, 2024 · 1 comment
Assignees
@schauder
Labels
in: additional-dialect Request for additional dialects status: declined A suggestion or change that we don't feel we should currently apply

Comments

@eddumelendez
Copy link

eddumelendez commented Nov 22, 2024 •
edited
Loading

ClickHouse provides an r2dbc driver. Building a project with Testcontainers fails because of the following exception:

Caused by: Caused by: org.springframework.data.r2dbc.dialect.DialectResolver$NoDialectException: Cannot determine a dialect for ClickHouse using ConnectionPool[ClickHouse]; Please provide a Dialect

Add ClickHouse to the list https://github.com/spring-projects/spring-data-relational/blob/main/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/DialectResolver.java#L113-L120

I had to add my own provider because of spring-projects/spring-framework#33947 and register it in spring.factories to reach out to this issue.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 22, 2024
@schauder
Copy link
Contributor

We currently don't have the capacity to add and support additional dialects.
But you can register your own Dialect using a DialectProvider

Related: #1770

@schauder schauder self-assigned this Nov 25, 2024
@schauder schauder added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 25, 2024
@schauder schauder closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
@schauder schauder added the in: additional-dialect Request for additional dialects label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
in: additional-dialect Request for additional dialects status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schauder @eddumelendez @spring-projects-issues