Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that keyspace events are not replicated across Redis Cluster shards #2881

Closed
wants to merge 1 commit into from

Conversation

kinsersh
Copy link
Contributor

@kinsersh kinsersh commented Mar 25, 2024

Applications can suffer from missing important Keyspace events as described at spring-projects/spring-session#2230.

This adds a caution to the docs to help others avoid running into this problem.

Related ticket #1111

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@kinsersh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 25, 2024
@kinsersh kinsersh force-pushed the main branch 3 times, most recently from 1daa85b to 41cff90 Compare March 26, 2024 20:58
@pivotal-cla
Copy link

@kinsersh Thank you for signing the Contributor License Agreement!

Applications can suffer from missing important Keyspace events as described at spring-projects/spring-session#2230.

This adds a caution to the docs to help others avoid running into this problem.

Related ticket spring-projects#1111
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 15, 2024
@mp911de mp911de self-assigned this Apr 15, 2024
mp911de pushed a commit that referenced this pull request Apr 16, 2024
…shards.

Applications can suffer from missing important Keyspace events as described at spring-projects/spring-session#2230.

This adds a caution to the docs to help others avoid running into this problem.

Closes #2881
mp911de added a commit that referenced this pull request Apr 16, 2024
Tweak wording.

See #2881
@mp911de mp911de closed this in 49e5afc Apr 16, 2024
mp911de added a commit that referenced this pull request Apr 16, 2024
Tweak wording.

See #2881
@mp911de mp911de added this to the 3.2.6 (2023.1.6) milestone Apr 16, 2024
@mp911de
Copy link
Member

mp911de commented Apr 16, 2024

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de changed the title Doc cautions about Redis Cluster keyspace events. Document that keyspace events are not replicated across Redis Cluster shards Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants