Register Converters for Offset java.time types in Jsr310Converters #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now appropriately handle OffsetDateTime and OffsetTime the same as all other java.time types, supported as simple types on Spring application (persistent) entity classes. Closes #2677
jxblum
added
in: mapping
jxblum
changed the title
Comment on lines
+54
to
+65
| new BinaryConverters.StringToBytesConverter(), | ||
| new BinaryConverters.BytesToStringConverter(), | ||
| new BinaryConverters.NumberToBytesConverter(), | ||
| new BinaryConverters.BytesToNumberConverterFactory(), | ||
| new BinaryConverters.EnumToBytesConverter(), | ||
| new BinaryConverters.BytesToEnumConverterFactory(), | ||
| new BinaryConverters.BooleanToBytesConverter(), | ||
| new BinaryConverters.BytesToBooleanConverter(), | ||
| new BinaryConverters.DateToBytesConverter(), | ||
| new BinaryConverters.BytesToDateConverter(), | ||
| new BinaryConverters.UuidToBytesConverter(), | ||
| new BinaryConverters.BytesToUuidConverter() |
There was a problem hiding this comment.
I think we can drop the extra BinaryConverters. part here.
| @@ -58,6 +61,7 @@ public abstract class Jsr310Converters { | |||
| } | |||
|
|
|||
| List<Converter<?, ?>> converters = new ArrayList<>(); | |||
There was a problem hiding this comment.
could be changed to List.of or initialized with an initial size.
| @@ -296,4 +304,51 @@ public Duration convert(byte[] source) { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * @author John Blum | |||
| * @see java.time.OffsetDateTime | |||
There was a problem hiding this comment.
though not a public class, having a @since tag can help with code forensic
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2677