Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds explicit mention of Valkey in the README. #3032

Closed

Conversation

stockholmux
Copy link
Contributor

A Valkey community member had questions about using this module with Valkey instead of Redis, this contribution aims directly answer this question.

Since both Valkey 7.2 and Redis 7.2 have the same API and and this repo has testing for Valkey, this change adds an explicit mention of Valkey in the README along side Redis.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@stockholmux Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 1, 2024
@mp911de
Copy link
Member

mp911de commented Nov 4, 2024

Hey Kyle, thanks for reaching out. Our strategy for now is to support Valkey on a best-effort basis.

@mp911de mp911de closed this in 88b3d66 Nov 7, 2024
mp911de added a commit that referenced this pull request Nov 7, 2024
Mention best-effort testing.

See #3032
mp911de pushed a commit that referenced this pull request Nov 7, 2024
mp911de added a commit that referenced this pull request Nov 7, 2024
Mention best-effort testing.

See #3032
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 7, 2024
@mp911de mp911de self-assigned this Nov 7, 2024
@mp911de mp911de added this to the 3.3.6 (2024.0.6) milestone Nov 7, 2024
@stockholmux
Copy link
Contributor Author

thanks @mp911de !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants