Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deserialization in GenericJackson2JsonRedisSerializer when using custom JsonFactory #2999

Closed
wants to merge 3 commits into from
Closed

Support deserialization in GenericJackson2JsonRedisSerializer when using custom JsonFactory #2999

wants to merge 3 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Sep 16, 2024

Closes #2981

@mp911de mp911de added the type: enhancement A general enhancement label Sep 16, 2024
@christophstrobl
Copy link
Member

do we actually need to parse the entire tree or can we pass in the name of the type hint and stop once we have it?

@mp911de
Copy link
Member Author

mp911de commented Sep 17, 2024

We cannot assume that the type property is at the start, it could be also the very last item. Looking at JsonNodeDeserializer._deserializeContainerNoRecursion, considering all possible cases doesn't seem trivial and so reading the full tree (as done before) seems have the best balance. When reading JSON, we could consider using TreeTraversingParser.

@christophstrobl
Copy link
Member

christophstrobl commented Oct 9, 2024 •
edited
Loading

Created a new ticket (#3012) for potential improvements that you outlined in 8aaf501 as those touch upon/change protected methods.

christophstrobl pushed a commit that referenced this pull request Oct 9, 2024
@mp911de @christophstrobl
Support deserialization in GenericJackson2JsonRedisSerializer when …
8c74d78 
…using custom `JsonFactory`.

Closes: #2981
Original Pull Request: #2999
christophstrobl added a commit that referenced this pull request Oct 9, 2024
@christophstrobl
Polishing.
f82b399 
Move JsonParser creation to dedicated method.

Original Pull Request: #2999
@christophstrobl
Copy link
Member

Merged those parts that are not modifying existing API to main development line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees

@christophstrobl christophstrobl

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support deserialization in GenericJackson2JsonRedisSerializer when using custom JsonFactory
2 participants
@mp911de @christophstrobl