okhttp supports custom protocols. gh-809 #820
Conversation
There was a problem hiding this comment.
Hello, @galaxy-sea. Actually, HTTP2 is supported by OkHttp and it's enabled by default. However, this PR is still useful. I have added comments - please address them.
Also, there's support in Apache HC5. We should add the support for it within gh-809 (can be in a separate PR) - will you work on that as well?
...gn-core/src/test/java/org/springframework/cloud/openfeign/FeignOkHttpConfigurationTests.java
Outdated
Show resolved
Hide resolved
...gn-core/src/test/java/org/springframework/cloud/openfeign/FeignOkHttpConfigurationTests.java
Outdated
Show resolved
Hide resolved
...n-core/src/test/java/org/springframework/cloud/openfeign/protocol/FeignOkProtocolsTests.java
Outdated
Show resolved
Hide resolved
...d-openfeign-core/src/test/java/org/springframework/cloud/openfeign/protocol/Application.java
Outdated
Show resolved
Hide resolved
...n-core/src/test/java/org/springframework/cloud/openfeign/protocol/FeignOkProtocolsTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks, @galaxy-sea. Have just added two cosmetic comments. Once this is done, we'll be able to merge it.
...n-core/src/test/java/org/springframework/cloud/openfeign/protocol/FeignOkProtocolsTests.java
Outdated
Show resolved
Hide resolved
...n-core/src/test/java/org/springframework/cloud/openfeign/protocol/FeignOkProtocolsTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks, @galaxy-sea, I see the build is failing on checkstyle:
/home/runner/work/spring-cloud-openfeign/spring-cloud-openfeign/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignOkHttpConfigurationTests.java:20:1: 'javax.net.ssl.HostnameVerifier' should be separated from previous imports.
There was a problem hiding this comment.
Thanks, @galaxy-sea, the build is failing on checkstyle:
/home/runner/work/spring-cloud-openfeign/spring-cloud-openfeign/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignOkHttpConfigurationTests.java:20:1: 'javax.net.ssl.HostnameVerifier' should be separated from previous imports. . Have added a comment - please fix.
| @@ -17,10 +17,10 @@ | |||
| package org.springframework.cloud.openfeign; | |||
|
|
|||
| import java.lang.reflect.Field; | |||
|
|
|||
There was a problem hiding this comment.
This is what is causing the build checkstyle failure - please revert this line deletion.
There was a problem hiding this comment.
Sorry, I resubmitted the code
|
@galaxy-sea I see there are some test failures that I would not expect as a result of your PR. Can you first merge changes from |
I submit |
|
Ok, @galaxy-sea - I'll take a look at it on Monday. |
|
Hi, @galaxy-sea, this is happening because the |
|
hello @OlgaMaciaszek ，Thank you for solving my doubts. It seems that I need to learn AOT. |
hello @OlgaMaciaszek , Complete the
OkHttpClientcustom protocol, butClient.DefaultandApacheHttp5Clientdo not support http2.