Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

consolidate spree_sass_blue_theme #8

Open
runlevel5 opened this issue Sep 16, 2012 · 4 comments
Open

consolidate spree_sass_blue_theme #8

runlevel5 opened this issue Sep 16, 2012 · 4 comments

Comments

@runlevel5
Copy link

Spree has adopted SCSS/SASS since version 1.1.x. It's about time to kill spree_sass_blue_theme and merge it back to spree_blue_theme

@TylerRick
Copy link

What? scss is the right direction to go. We use it in all our projects. Why would anyone want to go back to writing plain css files without all the niceness that sass provides?

sass-rails is included by Rails by default in all new projects.

spree itself uses sass. I count no less than 36 .scss files in the spree repository. Why would you not want to also use sass in your theme extensions as well?

Seriously, I hope that spree_blue_sass_theme is chosen as the way forward and that the changes from spree_blue_theme get merged into spree_blue_sass_theme.

@steveroot
Copy link

@TylerRick - I read this as 'When spree_sass_blue_theme was started, spree didn't use sass. Now spree_blue_theme can use sass so we don't need to keep them separate any more'.
So, spree_blue_theme will have/has all the sass goodness. Or maybe I read that wrong?

@TylerRick
Copy link

Haha, okay, maybe I just read it wrong. That's a great idea then! :) Having 2 out-of-sync repositories for the same theme is a big pain, and I've spent hours trying to get both of them working for me in Spree 1.3.

@runlevel5
Copy link
Author

@TylerRick can you dig in and cook us a pull request? Thanks in advance

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants