Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL for sprites is hardcoded #1052

Open
SimFre opened this issue Aug 9, 2023 · 1 comment
Open

URL for sprites is hardcoded #1052

SimFre opened this issue Aug 9, 2023 · 1 comment

Comments

@SimFre
Copy link

SimFre commented Aug 9, 2023

Hosting a personal copy of the alttpr site is a bit tricky when the URL to the sprites are hardcoded in SettingsController, rather than using a configuration option. Perhaps this should be part of .env? See: https://github.com/sporchia/alttp_vt_randomizer/blob/c602322bbb1f0bd7d8154b2ba4757f009623ed03/app/Http/Controllers/SettingsController.php#L222C1-L222C87

@sporchia
Copy link
Owner

If you'd like to make a PR adding an ENV var and config option for it we can look to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants