Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for group level access token #36

Open
M0roSan opened this issue Jan 27, 2022 · 6 comments · May be fixed by #50
Open

support for group level access token #36

M0roSan opened this issue Jan 27, 2022 · 6 comments · May be fixed by #50
Labels
enhancement New feature or request

Comments

@M0roSan
Copy link
Contributor

M0roSan commented Jan 27, 2022

14.7 added support for group level access token https://about.gitlab.com/releases/2022/01/22/gitlab-14-7-released/#group-access-tokens

we want to support this in this plugin.

depending on xanzy/go-gitlab#1347

@M0roSan M0roSan added the enhancement New feature or request label Jan 27, 2022
@M0roSan
Copy link
Contributor Author

M0roSan commented Mar 19, 2022

I'm making this as minor version update (feature addition) for this change. I'm adding a new parameter token_type in BaseTokenStorage with project or group and it'll change API call based on type field even though id field is unique amongst project and groups (confirmed with GitLab support).

there's no other significant changes. To note, group type will work with instance level (and/or group level) token which can create group access token

@M0roSan M0roSan linked a pull request Mar 19, 2022 that will close this issue
@EvertonSA
Copy link

hello grettings colleagues, can I do something to help here? I really wanna use this feature

@EvertonSA
Copy link

@M0roSan anything i can do to help mate?

@M0roSan
Copy link
Contributor Author

M0roSan commented Mar 8, 2023

@EvertonSA I currently don't have time to refine or don't have access to any gitlab instances with right license. You are more than welcome to test the existing MRs and add if needed

@EvertonSA
Copy link

hi @M0roSan I have tested and I confirm it works. There might be many errors handling to be implemented but unfortunately, I don't have golang experience to help on this feature.

Also, we will find a different approach to our problem at the moment. Thanks a lot for this feature, it helped us to brainstorm possible solutions to our problem.

@ilijamt
Copy link

ilijamt commented Aug 30, 2023

You can try this one https://github.com/ilijamt/vault-plugin-secrets-gitlab it supports all 3 access tokens. Personal, Project and Group tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants