Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: same trap ports #1143

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: same trap ports #1143

merged 2 commits into from
Dec 20, 2024

Conversation

ajasnosz
Copy link
Collaborator

@ajasnosz ajasnosz commented Dec 18, 2024 •
edited
Loading

Description

Redesigns the configuration for traps server to receive both IPv4 and Ipv6 traps on the same port.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Refactor/improvement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

manual, integration, unit

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ajasnosz ajasnosz force-pushed the fix/same-trap-ports branch from 78e82ec to 7c136b5 Compare December 19, 2024 13:24
@ajasnosz ajasnosz merged commit 704a556 into develop Dec 20, 2024
12 checks passed
@ajasnosz ajasnosz deleted the fix/same-trap-ports branch December 20, 2024 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.12.1-beta.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ikheifets-splunk ikheifets-splunk ikheifets-splunk approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajasnosz @srv-rr-github-token @ikheifets-splunk