Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature proposal] Allow for a "should not trigger" test type #326

Open
Res260 opened this issue Nov 14, 2024 · 0 comments
Open

[Feature proposal] Allow for a "should not trigger" test type #326

Res260 opened this issue Nov 14, 2024 · 0 comments

Comments

@Res260
Copy link
Contributor

Res260 commented Nov 14, 2024

Currently, the tests for a detection are tests that PASS if the log is found using the provided detection' search. This is great to test that the rule matches when it's supposed to match, but it cannot test the exclusions to a rule.

Proposal: Introduce the concept of test "types": "should trigger" and "should not trigger".

The behavior is very simple:

  • For a should trigger test: If the detection' search finds a log, the test PASSES. Else it FAILS.
  • For a should not trigger test: If the detection' search finds a log, the test FAILS. Else it PASSES.

I can work on this feature and contribute it to upstream. If this is not something you want, we'll keep it in our private fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant