fix: combining splunk versions #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -276,6 +277,12 @@ jobs: | |||
| run: | | |||
| echo "splunk={\"version\":\"unreleased-python3_9-7027496d63d8\", \"build\":\"7027496d63d8\", \"islatest\":false, \"isoldest\":false}" >> "$GITHUB_OUTPUT" | |||
| echo "sc4s={\"version\":\"2.49.5\", \"docker_registry\":\"ghcr.io/splunk/splunk-connect-for-syslog/container2\"}" >> "$GITHUB_OUTPUT" | |||
| - name: combined_Splunkmatrix | |||
There was a problem hiding this comment.
Consider removing python39_Splunk and adding logic to combined_Splunkmatrix.
Then all test jobs would require update of matrix and removal of python39 section.
There was a problem hiding this comment.
Lets postpone those changes for now and focus on delivering fix for modinput tests.
mkolasinski-splunk
approved these changes
Mar 26, 2024
|
🎉 This PR is included in version 4.15.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stage to combine splunk versions an use it in modinput test job.
Job in AWS addon where modinut is running successfully with python3.9 (Matrix of 24 jobs 3*8): https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/8431526533
Job in MSCS addon : https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/8431532363