Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove firefox from ui tests #228

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

kdoroszko-splunk
Copy link
Contributor

This PR removes firefox from ui tests execution, since firefox is ranked 4th in Desktop Browser Market Share Worldwide.
https://splunk.atlassian.net/browse/ADDON-68235
tested here: https://github.com/splunk/test-addonfactory-repo/actions/runs/7815971598/job/21320701943

@kdoroszko-splunk kdoroszko-splunk requested a review from a team as a code owner February 7, 2024 14:25
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have it as a feat because it is a customer-facing change.

@kdoroszko-splunk kdoroszko-splunk changed the title chore: remove firefox from ui tests feat: remove firefox from ui tests Feb 7, 2024
@kdoroszko-splunk
Copy link
Contributor Author

Let's have it as a feat because it is a customer-facing change.

Good point, done.

@artemrys artemrys merged commit 882f8d4 into develop Feb 7, 2024
6 checks passed
@artemrys artemrys deleted the chore/remove-firefox-from-ui-tests branch February 7, 2024 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants