Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revert unreleased python39 splunk #154

Merged
merged 3 commits into from
Nov 10, 2023
Merged

feat: revert unreleased python39 splunk #154

merged 3 commits into from
Nov 10, 2023

Conversation

mkolasinski-splunk
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk commented Nov 10, 2023 •
edited by artemrys
Loading

We found a way to include additional configuration in the job matrix (https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations), the workaround in this repository is not needed anymore.

@mkolasinski-splunk mkolasinski-splunk requested a review from a team as a code owner November 10, 2023 02:54
artemrys
artemrys reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we release a v1.12.0 with these changes? It's better not to manipulate with tags and fix messages.

@mkolasinski-splunk
Copy link
Contributor Author

mkolasinski-splunk commented Nov 10, 2023 •
edited
Loading

Can we release a v1.12.0 with these changes? It's better not to manipulate with tags and fix messages.

This PR is supposed to do exactly this to avoid tags manipulations.
I did git revert and collected all related changes into this one PR.

@mkolasinski-splunk mkolasinski-splunk changed the title fix: revert unreleased python39 splunk feat: revert unreleased python39 splunk Nov 10, 2023
@artemrys artemrys merged commit 3452334 into main Nov 10, 2023
3 checks passed
@artemrys artemrys deleted the fix/revert-unreleased-python39-splunk branch November 10, 2023 08:35
srv-rr-github-token added a commit that referenced this pull request Nov 10, 2023
@srv-rr-github-token
chore(release): 1.12.0
4bc3901 
# [1.12.0](v1.11.0...v1.12.0) (2023-11-10)

### Features

* revert unreleased python39 splunk ([#154](#154)) ([3452334](3452334)), closes [#153](#153) [#152](#152)
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemrys artemrys artemrys left review comments

@mbruzda-splunk mbruzda-splunk Awaiting requested review from mbruzda-splunk mbruzda-splunk is a code owner automatically assigned from splunk/products-gdi-addons-adminrepo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkolasinski-splunk @srv-rr-github-token @artemrys