Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reducer and actions #115

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Refactor reducer and actions #115

merged 3 commits into from
Sep 10, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Sep 6, 2024 •
edited
Loading

Redux SDK

What did you accomplish?

  • Refactor internal actions to get the timestamp from the client lastUpdate property, rather than calculating it again.
  • Refactor reducer to reuse some code.

How do we test the changes introduced in this PR?

  • Unit test updates.

Extra Notes

@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review September 9, 2024 19:36
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner September 9, 2024 19:36
@EmilianoSanchez EmilianoSanchez changed the title Refactor reducer and actions [WIP] Refactor reducer and actions Sep 9, 2024
@EmilianoSanchez EmilianoSanchez merged commit a51613a into status_properties_update Sep 10, 2024
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the refactor_reducer_and_actions branch September 10, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @sanzmauro