Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten line in docstring #450

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Shorten line in docstring #450

merged 1 commit into from
Dec 4, 2024

Conversation

sea-bass
Copy link
Collaborator

@sea-bass sea-bass commented Sep 3, 2024

My recent change seems to have broken the linter due to line length. Quick fix!

@sea-bass sea-bass requested a review from stonier September 3, 2024 11:27
@stonier
Copy link
Member

stonier commented Nov 25, 2024

@sea-bass can you remind me what the J and R represent on the ROS CI jobs means again? Is it Rolling and Jazzy?

And is the error here something ado with the ros ctesting pipeline? Complaining because it didn't find a test report (because no tests were run?)?

@sea-bass
Copy link
Collaborator Author

@sea-bass can you remind me what the J and R represent on the ROS CI jobs means again? Is it Rolling and Jazzy?

That's right, Rolling and Jazzy.

These 2 versions have in common that they use Ubuntu 24.04, so maybe something related to that?

@stonier
Copy link
Member

stonier commented Nov 25, 2024

This looks like it's Noble or ROS2 machinery that's flipping out on the fact that there are no tests in the ROS PR jobs now (which served mainly to smoke test deb builds). I didn't want to setup any test machinery in the ROS PR jobs - that's just duplicate configuration that's a pain to maintain for a package in which I used a non-ROS environment for developing.

I did some digging, but not getting any quick answers. Left a question at colcon/colcon-core#678 too.

One thing we could try is to explicitly add pytest to that setup.py along with a fake test that always passes to point it at.

@sea-bass
Copy link
Collaborator Author

sea-bass commented Nov 26, 2024

Looks like their suggestion was exactly your idea -- seems like that's the plan!

@sea-bass
Copy link
Collaborator Author

sea-bass commented Dec 4, 2024

Merging this for the formatting fix

@sea-bass sea-bass merged commit 7f701d5 into devel Dec 4, 2024
4 of 6 checks passed
@sea-bass sea-bass deleted the shorten-docstring-line branch December 4, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants