Skip to content

Commit

Permalink
[composites] show ghost states for sequence children
Browse files Browse the repository at this point in the history
Reverts the *new* behaviour introduced in #330 for sequences
with memory. This shouldn't have made it into a patch
release (surprise factor) and there is some debate on what
the best approach is. Refer to the discussion in #328.
  • Loading branch information
stonier committed May 27, 2021
1 parent a7d12b7 commit 274382f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Release Notes
Forthcoming
-----------
* [tests] mypy conformance, `#327 <https://github.com/splintered-reality/py_trees/pull/327>`_
* [composites] show ghost states for sequence children, `#330 <https://github.com/splintered-reality/py_trees/pull/330>`_ (reverts behaviour introduced in `#325 <https://github.com/splintered-reality/py_trees/pull/325>`_)

2.1.5 (2021-05-09)
------------------
Expand Down
6 changes: 0 additions & 6 deletions py_trees/composites.py
Original file line number Diff line number Diff line change
Expand Up @@ -440,12 +440,6 @@ def tick(self):
child.stop(common.Status.INVALID)
# user specific initialisation
self.initialise()
else: # self.memory is True and status is RUNNING
index = self.children.index(self.current_child)
# clear out preceding status' - not actually necessary but helps
# visualise the case of memory vs no memory
for child in itertools.islice(self.children, None, index):
child.stop(common.Status.INVALID)

# customised work
self.update()
Expand Down

0 comments on commit 274382f

Please sign in to comment.