Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-passive event listeners #199

Open
YevheniiKisel opened this issue Jul 10, 2024 · 1 comment
Open

Non-passive event listeners #199

YevheniiKisel opened this issue Jul 10, 2024 · 1 comment

Comments

@YevheniiKisel
Copy link

YevheniiKisel commented Jul 10, 2024

Hello, Spline community!
I have a question regarding a non-passive event warning in the console, a.k.a "[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event." which is also mentioned in the Lighthouse post-test recommendations.
I have a problem exactly with scrolling, which feels "jumpy + low FPS" :). After a quick examination of the source code of the @splinetool/runtime there is indeed a lack of { passive: true } in the event listener declaration. ?

    "@splinetool/react-spline": "^4.0.0",
    "@splinetool/runtime": "^1.8.9",
    "next": "^14.2.3",

Here is a reference article: https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md

I would really be thankful for your fix or any help.

Thank you!

@olafrv
Copy link

olafrv commented Oct 25, 2024

Example: https://my.spline.design/olafufoanime-eac50b1e97e47009815286a718bf5e84/

[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event.
[Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants