Move Repository::address to dedicated trait #1153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible for other things to have a trait bound on `Address` instead of all of `Repository`, which means other types can implement `Address` without having to also implement all of `Repository` (not shown in this commit). Also change the method signature to return `Cow` since there are cases where an existing `Url` value can be borrowed. Signed-off-by: J Robert Ray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for other things to have a trait bound on
Addressinstead of all ofRepository, which means other types can implementAddresswithout having to also implement all ofRepository(not shown in this commit).Also change the method signature to return
Cowsince there are cases where an existingUrlvalue can be borrowed.