Skip to content

Commit

Permalink
chore(experiment): Proposal for changing/standardizing monitoring dat…
Browse files Browse the repository at this point in the history
…a model

See spinnaker-monitoring-daemon/experimental/README.md for more info about the proposal.
This PR is a working specification along with new dashboards for Prometheus and Stackdriver.
They are relegated to an "experimental" tag to sit outside the production codepaths,
but are fully working and compatible with production microservice (and daemon) deployments.

There are no Spinnaker code changes involved, only configuration.
The persistent metric data collected will be incompatible with previous production microservices
when choosing to opt-in to using the provided configuration.
  • Loading branch information
Eric Wiseblatt committed Jan 4, 2019
1 parent ce2e075 commit 4279215
Show file tree
Hide file tree
Showing 34 changed files with 30,095 additions and 0 deletions.
492 changes: 492 additions & 0 deletions spinnaker-monitoring-daemon/experimental/README.md

Large diffs are not rendered by default.

1,725 changes: 1,725 additions & 0 deletions spinnaker-monitoring-daemon/experimental/metric_filters/default.yml

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
prometheus:
# By default, for historical reasons, spinnaker uses ':' as a hierarchical
# separator in prometheus metric names. This is non-0standard for prometheus
# and, in fact, unadvised.
#
# Setting this option to True will use standard notation ('_') instead of ':'.
# Note that this is incompmatible with the published dashboards however is
# required for the experimental dashboards.
use_standard_notation: True

datadog:
# This is false by default for historical compatability.
# If/when new dashboards are written for datadog, have them based on this
# being true.
# Historically datadog metrics were written without types, meaning they were
# gauges. By setting this to true, meter type information will be reported so
# spectator counters will become datadog counters.
# use_types: true

spectator:
# Do not decorate metric names with a service prefix.
# This is true by default for historic compatability, however
# is no longer needed/desired given the spin_* tags.
decorate_metric_name: false

# Do not alias service names to their base service names.
# When true this would turn "clouddriver-readonly" to "clouddriver"
# When false this leaves "clouddriver-readonly" as is.
# This is true by default for historic compatability, however
# is no longer needed/desired given the spin_* tags.
use_base_service_name_only: false

# Adds spin_service and spin_variant tags for each metric
# This also changes the defaults of
# decorate_metric_name and use_base_service_name_only to "false"
inject_service_tag: true
Loading

0 comments on commit 4279215

Please sign in to comment.