New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/agent] Change method of obtaining cluster AgentsList from backend agent db #10

Open

lumjjb opened this issue Aug 17, 2021 · 0 comments

Labels

backend

Collaborator

lumjjb commented Aug 17, 2021 •

edited

Loading

MOVED FROM ORIGINAL REPO https://github.com/lumjjb/tornjak/issues/71

The way agents are parsed in the DB processor is via splitting on , via a concat query in the database:

Line of code below [uses strings.split(",")]
https://github.com/lumjjb/tornjak/blob/6c126e316a157548ca9835773feb522c56bf5f6b/tornjak-backend/pkg/agent/db/sqlite.go#L209

This probably can be handled better, in case spiffeids for some reason include ,s, which shouldn't be the case at least.

The text was updated successfully, but these errors were encountered:

mrsabath added the backend label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment