Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.22.3, fix Dockerfile warnings #174

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Update to go 1.22.3, fix Dockerfile warnings #174

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d72898e
Update to go 1.22.3, fix Dockerfile warnings
faisal-memon Aug 28, 2024
eff6c38
Merge branch 'main' into release-build-docker
faisal-memon Aug 29, 2024
cbf079f
Remove default version from dockerfile
faisal-memon Sep 7, 2024
50ae442
Merge branch 'main' into release-build-docker
faisal-memon Sep 10, 2024
5105610
Merge branch 'main' into release-build-docker
faisal-memon Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/tests/it/spiffe-helper/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.1-alpine AS spiffe-helper
FROM golang:1.22.3-alpine AS spiffe-helper
COPY ./ /service/
WORKDIR /service
RUN go build -tags netgo -a -v -o /service/spiffe-helper ./cmd/spiffe-helper
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Build the spiffe-helper binary
ARG go_version
FROM --platform=$BUILDPLATFORM golang:${go_version}-alpine as base
ARG go_version=1.22.3
faisal-memon marked this conversation as resolved.
Show resolved Hide resolved
FROM --platform=$BUILDPLATFORM golang:${go_version}-alpine AS base
WORKDIR /workspace

# Cache deps before building and copying source so that we don't need to re-download as much
Expand All @@ -18,7 +18,7 @@ COPY pkg/ pkg/
# crane digest tonistiigi/xx:1.3.0
FROM --platform=${BUILDPLATFORM} tonistiigi/xx@sha256:904fe94f236d36d65aeb5a2462f88f2c537b8360475f6342e7599194f291fb7e AS xx

FROM --platform=${BUILDPLATFORM} base as builder
FROM --platform=${BUILDPLATFORM} base AS builder
ARG TARGETPLATFORM
ARG TARGETARCH

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/spiffe/spiffe-helper

go 1.22.1
go 1.22.3

require (
github.com/hashicorp/hcl v1.0.0
Expand Down
Loading