Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daemon mode flag #161

Merged
merged 14 commits into from
Aug 27, 2024
Merged

Add daemon mode flag #161

merged 14 commits into from
Aug 27, 2024

Conversation

faisal-memon
Copy link
Collaborator

@faisal-memon faisal-memon commented May 21, 2024

  • Add a daemon_mode configurable to toggle running spiffe-helper as a daemon. When daemon mode is disabled x509 and/or jwts are downloaded and spiffe-helper exits.
  • Add a daemon-mode cli flag to override config file setting and disable daemon mode.

Base automatically changed from fix-caps to main June 26, 2024 13:14
@faisal-memon faisal-memon force-pushed the daemon branch 2 times, most recently from 7bac373 to e6e9234 Compare July 1, 2024 22:49
@faisal-memon faisal-memon marked this pull request as ready for review July 2, 2024 00:21
@faisal-memon faisal-memon requested a review from MarcosDY as a code owner July 2, 2024 00:21
@faisal-memon faisal-memon marked this pull request as draft July 2, 2024 01:20
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
@faisal-memon faisal-memon marked this pull request as ready for review July 2, 2024 22:31
cmd/spiffe-helper/config/config.go Outdated Show resolved Hide resolved
cmd/spiffe-helper/config/config.go Outdated Show resolved Hide resolved
cmd/spiffe-helper/main.go Outdated Show resolved Hide resolved
cmd/spiffe-helper/main.go Outdated Show resolved Hide resolved
faisal-memon and others added 2 commits July 3, 2024 16:40
Signed-off-by: Faisal Memon <[email protected]>

Co-authored-by: Marcos Yacob <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Co-authored-by: Marcos Yacob <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
pkg/sidecar/config.go Outdated Show resolved Hide resolved
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
@faisal-memon faisal-memon merged commit 9dcaa32 into main Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants