Indexing Error on Last Bin

[magsreed]

detanalysis/detanalysis/semiautocuts.py

Lines 1016 to 1019 in 0be0395

	current_mask = self._get_cut_mask(ofamp_lims=ofamp_lims_arr, cut_pars=current_exception_pars,
	lgcdiagnostics=lgcdiagnostics,
	include_previous_cuts=include_previous_cuts,
	on_cut_bin =i + 1)

There appears to be an indexing error on the last bin for amplitude cuts.

Diagnosis:

Adding the following print statements before lines

detanalysis/detanalysis/semiautocuts.py

Line 621 in 0be0395

self.values_upper[on_cut_bin] = cut_pars['val_upper']

-> print(f'on_cut_bin', on_cut_bin)
-> print(f'values_upper size: ', len(self.values_upper))

Input code:

ofamp_limits = [-1e-8,-0.5e-8, 0.0, 1e-8]
cut_exception_pars = {'val_upper': 2.8e3, 'val_lower': 0.}
exceptions_dict = {0: cut_exception_pars, 1: cut_exception_pars, 2: cut_exception_pars, 3: cut_exception_pars}
chi2_cut = Semiautocut(myanalyzer_feature.df, cut_rq = 'lowchi2_of1x1_nodelay', channel_name='IrPtTES100x25',
                               cut_pars=cut_pars_chi2, ofamp_bins = ofamp_limits,
                      exceptions_dict=exceptions_dict)

Results:

on_cut_bin: 0
val_upper size: 4
on_cut_bin: 1
val_upper size: 4
on_cut_bin: 2
val_upper size: 4
on_cut_bin: 4
val_upper size: 4

Results above indicate over indexing on the last bin only. Simple fix is to remove the extraneous +=1 on

detanalysis/detanalysis/semiautocuts.py

Lines 1016 to 1019 in 0be0395

	current_mask = self._get_cut_mask(ofamp_lims=ofamp_lims_arr, cut_pars=current_exception_pars,
	lgcdiagnostics=lgcdiagnostics,
	include_previous_cuts=include_previous_cuts,
	on_cut_bin =i + 1)

Above appears to index i twice on the last bin, thus overshooting. I am submitting the issue and then immediately fixing with a PR request as I just tested if removing the extra indexing on the last bin fixes the issue totally, and had success.