Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esbonio build fails with WinError 2: File in use error when renaming temporary file #94

Open
JensWalther opened this issue May 29, 2024 · 2 comments

Comments

@JensWalther
Copy link

https://github.com/sphinx-contrib/plantuml/blame/09f9d13c44bdbfb73974159cedd29bb1d2e08f69/sphinxcontrib/plantuml.py#L411

This close statement is "double" closing the temporary file causing the rename to fail occasionally. Observed with v.29 wheel file.

v.26 does not show this error.

@JensWalther
Copy link
Author

The rename must happen behind the 'with' block as the explicit close inside the with block is incorrect and can cause undefined behavior such as the file not being closed. This causes the rename to fail

@xfornari
Copy link

xfornari commented Sep 4, 2024

I observe the same (v.30) and had to go back to v.26 as JensWalther mentionned (running on Windows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants