Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

key auto lower? #293

Closed
elvizlai opened this issue Dec 22, 2016 · 3 comments
Closed

key auto lower? #293

elvizlai opened this issue Dec 22, 2016 · 3 comments

Comments

@elvizlai
Copy link

elvizlai commented Dec 22, 2016 •
edited
Loading 

ENV:
    REPO: [email protected]:xyz/abc.git
    WORKDIR: /gopath/src/github.com/xyz/abc
type conf struct {
    ENV    map[string]string
}

Updating viper to newest, the key are all lower.(Previous version works well)
@bep
Copy link
Collaborator

bep commented Dec 22, 2016

Yes, that is a change. The Get* methods are also case insensitive.

@bep bep closed this as completed Dec 22, 2016
@elvizlai
Copy link
Author

Any way to make it sensitive? It is not reasonable.

@e-nikolov e-nikolov mentioned this issue Nov 7, 2018
Closed
knadh added a commit to knadh/viper that referenced this issue Jan 25, 2019
@knadh
Add viper.SetKeyCaseSensitivity() to disable automatic key lowercasing.
ef64cb3 
YAML, TOML, and JSON dictate keys to be case-sensitive. Viper's default
behaviour of lowercasing the keys for key insensitivity is incompatible
with these standards and has the side effect of making it difficult for
use cases such as case sensitive API credentials in configuration.
For eg: MyApiKey=MySecret (in TOML).

See spf13#131, spf13#260, spf13#293, spf13#371, spf13#373

This commit adds a global function `viper.SetKeyCaseSensitivity()` that
enables this behaviour to be turned off, after which, all keys, irrespective
of nesting, retain their cases. This respects all configuration operations
including getting, setting, and merging.
@knadh knadh mentioned this issue Jan 25, 2019
Closed
knadh added a commit to knadh/viper that referenced this issue Jan 29, 2019
@knadh
Add viper.SetKeyCaseSensitivity() to disable automatic key lowercasing.
176728a 
YAML, TOML, and JSON dictate keys to be case-sensitive. Viper's default
behaviour of lowercasing the keys for key insensitivity is incompatible
with these standards and has the side effect of making it difficult for
use cases such as case sensitive API credentials in configuration.
For eg: MyApiKey=MySecret (in TOML).

See spf13#131, spf13#260, spf13#293, spf13#371, spf13#373

This commit adds a global function `viper.SetKeyCaseSensitivity()` that
enables this behaviour to be turned off, after which, all keys, irrespective
of nesting, retain their cases. This respects all configuration operations
including getting, setting, and merging.
knadh added a commit to knadh/viper that referenced this issue Jan 29, 2019
@knadh
Add viper.SetKeysCaseSensitive() to disable automatic key lowercasing.
2cb5cbf 
YAML, TOML, and JSON dictate keys to be case-sensitive. Viper's default
behaviour of lowercasing the keys for key insensitivity is incompatible
with these standards and has the side effect of making it difficult for
use cases such as case sensitive API credentials in configuration.
For eg: MyApiKey=MySecret (in TOML).

See spf13#131, spf13#260, spf13#293, spf13#371, spf13#373

This commit adds a global function `viper.SetKeysCaseSensitive()` that
enables this behaviour to be turned off, after which, all keys, irrespective
of nesting, retain their cases. This respects all configuration operations
including getting, setting, and merging.
This was referenced Aug 30, 2019
Closed
Merged
@dmitry-irtegov dmitry-irtegov mentioned this issue Mar 16, 2020
Open
@sagikazarmark
Copy link
Collaborator

See #1014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bep @elvizlai @sagikazarmark