Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INI Configs do not support viper.GetStringSlice(), but YAML does #1675

Open
3 tasks done
mpenning opened this issue Nov 8, 2023 · 1 comment
Open
3 tasks done

INI Configs do not support viper.GetStringSlice(), but YAML does #1675

mpenning opened this issue Nov 8, 2023 · 1 comment
Labels
kind/bug Something isn't working

Comments

@mpenning
Copy link

mpenning commented Nov 8, 2023

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.
  • I have checked the troubleshooting guide for my problem, without success.

Viper Version

1.17

Go Version

1.20

Config Source

Files

Format

INI

Repl.it link

No response

Code reproducing the issue

configReader := viper.New()
  configReader.AddConfigPath(".") // read from this directory
  configReader.SetConfigName("this.yaml")
  configReader.SetConfigType("yaml")
  err := configReader.ReadInConfig()
  if err != nil {
    logoru.Critical(err)
  }
  // Read the slice of commands listed under the ssh_logger / commands keys...
  myCommands := configReader.GetStringSlice("ssh_logger.commands")

Expected Behavior

If using configReader.SetConfigName("this.ini") and configReader.ConfigType("ini")above, configReader.GetStringSlice("ssh_logger.command") iterates over WORDS, not LINES...

[ssh_logger]
commands =
    terminal length 0
    show ip route 1.1.1.1

Actual Behavior

If using configReader.SetConfigName("this.ini") and configReader.ConfigType("ini")above, configReader.GetStringSlice("ssh_logger.command") iterates over WORDS, not LINES... specifically, GetStringSlice() returns {"terminal", "length", "0", "show", "ip", "route", "1.1.1.1"}.

[ssh_logger]
commands =
    terminal length 0
    show ip route 1.1.1.1

Using configReader.SetConfigType("yaml") and a YAML configuration work correctly... GetStringSlice() returns {"terminal length 0", "show ip route 1.1.1.1"}.

Steps To Reproduce

See above

Additional Information

No response

@mpenning mpenning added the kind/bug Something isn't working label Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant