Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems reported by PHPStan #191

Open
szepeviktor opened this issue Aug 27, 2023 · 5 comments
Open

Fix problems reported by PHPStan #191

szepeviktor opened this issue Aug 27, 2023 · 5 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Aug 27, 2023 •
edited
Loading

It would be nice to have a UsesXPathFilters::filterExtractAttribute beside filterExtractAttributes.
One would return array<string>, the other array<array<string>>.
@spekulatius
Copy link
Owner

Which use-cases do you want to cover? You could also try filterFirstExtractAttribute to see if it works for your needs.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Aug 27, 2023 •
edited
Loading

Which use-cases do you want to cover?

To make static analysis possible.
Because the return types are different.

I know, I know. Popular software come with the liberty of using one method for several purposes. But I am not intended to be popular!

@spekulatius
Copy link
Owner

Okay, feel free to propose a PR :) Maybe after we got the PHPStan branch merged?

@szepeviktor
Copy link
Contributor Author

I do not have plans to contribute more.

@spekulatius
Copy link
Owner

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @spekulatius