Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEB-2171: Non-Speckle Materials Fix #3558

Merged
merged 3 commits into from
Nov 26, 2024
Merged

WEB-2171: Non-Speckle Materials Fix #3558

merged 3 commits into from
Nov 26, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Non speckle materials no longer throw an error

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@linear Linear
Copy link

linear bot commented Nov 26, 2024

WEB-2171 Maybe not throw when trying to use non speckle materials?

@github-actions GitHub Actions
Copy link
Contributor

📸 Preview service has generated an image.

iainsproat
iainsproat approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@iainsproat iainsproat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexandruPopovici AlexandruPopovici merged commit e739ee1 into main Nov 26, 2024
28 of 30 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/WEB-2171 branch November 26, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainsproat iainsproat iainsproat approved these changes

@didimitrie didimitrie Awaiting requested review from didimitrie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandruPopovici @iainsproat