You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am also supportive of removing a dependency that provides little benefit. I tried to replace uritools functions with urllib equivalents and hit some issues though.
RFC 3986 is considered the current standard and any future changes to
urlparse module should conform with it. The urlparse module is
currently not entirely compliant with this RFC due to defacto
scenarios for parsing, and for backward compatibility purposes, some
parsing quirks from older RFCs are retained. The testcases in
test_urlparse.py provides a good indicator of parsing behavior.
I wonder if urllib not being compliant with RFC 3986 is why uritools is used instead of urllib? Maybe the need for compliance with RFC 3986 is strong enough to merit adding a dependency on uritools? I personally don't know. But when I tried some simple replacements, it didn't go well :)
Why use uritools instead of the standard library urllib?
Are there specific cases that really demand adding an extra dependency?
It seems barely used https://github.com/search?q=repo%3Aspdx%2Ftools-python+uritools+language%3APython&type=code&l=Python
and it would be best to avoid adding an extra dependency for such a small benefit.
The text was updated successfully, but these errors were encountered: