Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication in JSON schema: crossRefs and seeAlsos #826

Closed
nicoweidner opened this issue Dec 19, 2022 · 4 comments
Closed

Duplication in JSON schema: crossRefs and seeAlsos #826

nicoweidner opened this issue Dec 19, 2022 · 4 comments

Comments

@nicoweidner
Copy link

Extracted licensing infos in the json schema have a crossRefs property as well as a seeAlsos property. Looking at the tag/value spec and the rdf example listed there, I suspect there should only be seeAlsos, and crossRefs is unused: https://spdx.github.io/spdx-spec/v2.3/other-licensing-information-detected/#104-license-cross-reference-field

@goneall
Copy link
Member

goneall commented Dec 19, 2022

This is related to #46 - crossRefs are one of the listed license specific fields used in the license list XML. We could remove this from the JSON schema, or we could add the license list XML fields to the spec as suggested in issue #46

@nicoweidner
Copy link
Author

Hm, I see. I vaguely remembered having read about it before. I stumbled across it while working on the Python tools. If the status of crossRefs is not so clear, it's probably ok not to support them for now, right?

@goneall
Copy link
Member

goneall commented Dec 19, 2022

If the status of crossRefs is not so clear, it's probably ok not to support them for now, right?

I completely agree that it is not necessary to support crossRefs in Python (or any other language tools) before we conclude on #46.

@goneall
Copy link
Member

goneall commented Apr 4, 2024

I believe this is resolved in 3.0

@goneall goneall closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants