-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add general software profile example #78
Conversation
cc @goneall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rnjudge - could you add a brief README.md file in the example13 folder that explains the diagram?
20f0249
to
9f21c6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pulling this example together!
Example looks good. Approving it for now.
Would it be possible to create a subsequent patch move example-13-spdx-3.json. to spdx-3.0/example3.
9f21c6d
to
e741b4b
Compare
@kestewart I tried to move around the files in accordance with your suggestion for organization. Look ok? |
Looks great Rose! Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are other issues with the JSON, we can fix them in a later PR.
This commit adds the software profile example drawio file and screenshot of the drawio diagram. The hope is that other profiles will build on top of this core example and we can generate SPDX docs for these examples to make adopting 3.0 easier. Signed-off-by: Rose Judge <[email protected]>
e741b4b
to
b0d664c
Compare
Based on @zvr comment above - I'll go ahead and merge |
This commit adds the software profile example drawio file and screenshot of the drawio diagram. The hope is that other profiles will build on top of this core example and we can generate SPDX docs for these examples to make adopting 3.0 easier.