buildView() overrides

[ilkermutlu]

I've been using standard Laravel mailables in my project and had a couple of tests asserting some string in the mailable HTML like

        $mailable = new UserInvitation($userInvitation);
        $mailable->assertSeeInHtml($url);

After migrating my mailables to this package, this assertion started erroring with:

 Illuminate\Support\HtmlString::__toString(): Return value must be of type string, null returned

  at vendor/laravel/framework/src/Illuminate/Support/HtmlString.php:64
     60▕      * @return string
     61▕      */
     62▕     public function __toString()
     63▕     {
  ➜  64▕         return $this->toHtml();
     65▕     }
     66▕ }
     67▕ 

After some digging, I see that the original buildView() method is as follows:

        if (isset($this->html)) {
            return array_filter([
                'html' => new HtmlString($this->html),
                'text' => $this->textView ?? null,
            ]);
        }

And the corresponding part of the override in the package:

        $html = $renderer->renderHtmlLayout($viewData);
        $text = $renderer->renderTextLayout($viewData);

        return array_filter([
            'html' => new HtmlString($html),
            'text' => new HtmlString($text) ?? null,
        ]);

I saw that the renderTextLayout() method is already returning consistently with the original method signature:

        if (! $this->mailTemplate->getTextTemplate()) {
            return $this->textView ?? null;
        }

So, I tried replacing 'text' => new HtmlString($text) ?? null with 'text' => $text and got the tests passing.

Considering renderTextLayout() will always return null when there is no text template (which is optional), any assertion on the html template will generate this same error.

I am not yet sure about further side effects of the change I made, therefore not submitting a PR.

I'd appreciate any insight into this.