Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on naming of include folder #8

Open
donovanhide opened this issue Sep 30, 2016 · 4 comments
Open

Decide on naming of include folder #8

donovanhide opened this issue Sep 30, 2016 · 4 comments

Comments

@donovanhide
Copy link
Contributor

If this project is to become supported by package installation tools such as brew and apt in the future, the include path will conflict with that of the legacy project. What is a suitable alternative name?

@PhilipDeegan
Copy link
Member

sparsehash11 ?

Keeping "sparsehash" could cause conflicts as you say, but changing it will force people to create sym links/modify include paths.

Bit of a toss up either way.

@david-grs
Copy link
Collaborator

It might be off topic, but why should this library be a fork? why not merge the changes to the main sparsehash? If everything is backward compatible - and that will be the case - I don't really see a reason to have 2 similar libraries.

On top of that, C++11 is old now, 14 is out and 17 will be here very soon. Naming it sparsehash11 sounds odd to me as it is already outdated before it's out :)

@donovanhide
Copy link
Contributor Author

@david-grs sorry for the late reply...

I'd love to merge this code back into the other repo, but I live in fear of breaking anything that depends on apt/brew/yum packages derived from that repo. Maybe I'm being paranoid...

@PhilipDeegan
Copy link
Member

@david-grs I think you're right, at least by now if someone's not using a C++11 compiler that's their own problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants