Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparse_hash_map: Replace insert function series with emplace equivalents #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sparse_hash_map: Replace insert function series with emplace equivalents #50

wants to merge 1 commit into from

Conversation

brandonfoong
Copy link
Contributor

Closes #49.
This PR replaces the insert and set series of functions in sparse_hashtableand sparsetable with their emplace and set_inplace equivalents. The helper functions are now named insert.../set, but their behaviour follows that of emplace.../set_inplace.
This is done to make it more consistent with the implementation of dense_hashtable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring sparse_hash_map::emplace's helper functions
1 participant
@brandonfoong