-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On the validity score (improving understanding and/or modifications) #44
Comments
Related:
I.e. relaxing the Gaussian assumption (Frechet --> Wasserstein) (from abstract)
|
I think that the score is a good one. I didn't think of the point regarding the difficulty in generating anything but P1 - so the bit of text that you added there certainly helps to motivate the score. I might call it something like If you wanted to check for chemical bonding validity an interesting approach might be to calculate the elemental embeddings using our recent |
@keeeto I like the idea of considering both structural and chemical validity, which is in line with some other recent changes #39 (comment). I've been hoping to use SkipAtom at some point, so I'm glad you're bringing it up in this context. I've also been interested in using it as the elemental featurizer for CrabNet in a Matbench submission for |
Oh - that sounds cool. I will be really interested to hear how SkipAtom + CrabNet works :). BTW we have been using a slight mod of CrabNet in an upcoming piece of work - nice to see some good cross-pollintaion; Open Source win!!! |
https://twitter.com/keeeto2000/status/1555143104650428419 by @keeeto (@keeeto2000 on Twitter)
As_a_distance_between_probability_distributions_(the_FID_score) has a "see also" to Wasserstein_metric § Normal_distributions
And in the Fréchet inception distance wiki article:
Wondering whether this needs to be renamed, explained differently, or if it needs to be changed to a different calculation. The intention behind the validity score is to ensure that the generated structures are "reasonable" and "valid" (i.e. realistic), and a set of structures with a similar space group number distribution to known structures from train+test seemed like a good way to tell, especially with the difficulty some models have had with generating structures other than P1 symmetry. Using
e_above_hull
would be another option, but this requires a high-fidelity property predictor and could lead to bias depending on the model used.The text was updated successfully, but these errors were encountered: