Require -numUnits in postcli #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before performing a potentially destructive action such as initialization
Codecov Report
@@ Coverage Diff @@
## develop #241 +/- ##
=======================================
Coverage 68.6% 68.6%
=======================================
Files 28 28
Lines 1862 1862
=======================================
Hits 1279 1279
Misses 435 435
Partials 148 148 |
Explicitly check whether value has been set. In previous code user could still pass -numUnits 0.
fasmat
approved these changes
Sep 20, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #239
Closes #236
This is a much simpler, stopgap fix for this issue that doesn't require changing the lower level post code.