Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a -clean argument to postcli #218

Closed
reythia opened this issue Aug 14, 2023 · 1 comment
Closed

Add a -clean argument to postcli #218

reythia opened this issue Aug 14, 2023 · 1 comment

Comments

@reythia
Copy link

reythia commented Aug 14, 2023

No spacemesh app should delete postbin data without explicit consent from the user.

I had a hairy few days after running either -verify or -genproof with all arguments expect numunits present. It took the default numunits of 4, ignored the postdata_metadata config and proceeded to wipe out TiBs of data it deemed redundant in the blink of an eye.

I've commented out the entire removeRedundantFiles routine in my local version but if there's a use case for it then it needs to be called explicitly ie by supplying -clean to postcli. It can't be chained into other calls as a side effect.

@lrettig
Copy link
Member

lrettig commented Oct 23, 2023

This was addressed in #241

@lrettig lrettig closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants