Add versioning to PoST data directory via postdata_metadata.json file #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
changed the title
fasmat
force-pushed
the
210-introduce-data-migration
branch
2 times, most recently
from
5e5bed7 to
8546cbf
Compare
fasmat
force-pushed
the
210-introduce-data-migration
branch
from
5683089 to
51e58d3
Compare
fasmat
force-pushed
the
210-introduce-data-migration
branch
3 times, most recently
from
9c13377 to
40c62a1
Compare
fasmat
force-pushed
the
210-introduce-data-migration
branch
from
40c62a1 to
bc3a2e2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #211 +/- ##
=========================================
- Coverage 59.8% 59.0% -0.9%
=========================================
Files 30 31 +1
Lines 2291 2407 +116
=========================================
+ Hits 1372 1421 +49
- Misses 781 835 +54
- Partials 138 151 +13 ☔ View full report in Codecov by Sentry. |
fasmat
changed the title
fasmat
force-pushed
the
210-introduce-data-migration
branch
3 times, most recently
from
dde5915 to
2971af2
Compare
fasmat
force-pushed
the
210-introduce-data-migration
branch
from
2971af2 to
b8d87fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces versioning to PoST data (closes #210 ). The version is stored inside the
postdata_metadata.jsonfile. If no version is present Version 0 is assumed which will be migrated to version 1.Version 1 has the following changes over Version 0:
Nonceis present.ScryptParamsthat were used to generate the PoST data were added to the metadata file.These additions allow changes to how the data is stored on disk and allow for smooth migrations from an older version of PoST to a newer version.
TODO:
libpostrs@poszu