Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start profiler timer until disk is spun up #131

Open
lrettig opened this issue Sep 22, 2023 · 0 comments
Open

Don't start profiler timer until disk is spun up #131

lrettig opened this issue Sep 22, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lrettig
Copy link
Member

lrettig commented Sep 22, 2023

I noticed that when I run the profiler on a dedicated disk that's in deep sleep, the first read is extra slow, but a subsequent read is faster:

> profiler -t 0 -n 144 --data-file /mnt/smesher-02/post/7c8cef2b/postdata_0.bin
{
  "time_s": 12.901740377,
  "speed_gib_s": 0.07750892288785359
}
> profiler -t 0 -n 144 --data-file /mnt/smesher-02/post/7c8cef2b/postdata_0.bin
{
  "time_s": 11.053322122,
  "speed_gib_s": 0.18094107616924474
}
> profiler -t 0 -n 144 --data-file /mnt/smesher-02/post/7c8cef2b/postdata_1.bin
{
  "time_s": 10.225100351,
  "speed_gib_s": 0.1955971023604089
}

(Changing nonces and threads here has no impact.)

Profiler should be smart enough to handle this case. It's probably as easy as having it perform one tiny "dummy read" before the timer starts, to make sure the disk is awake.

@poszu poszu added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Oct 2, 2023
@poszu poszu moved this to 📋 Backlog in Dev team kanban Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants