New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up SmesherID #174

Open

lrettig opened this issue Aug 9, 2022 · 0 comments

Member

lrettig commented Aug 9, 2022 •

edited

Loading

We have contradictory types for smesherID:

api/proto/spacemesh/v1/smesher_types.proto

Lines 52 to 54 in 9474f58

    
           message SmesherIDResponse { 
        
               AccountId account_id = 1; 
        
           }

and

api/proto/spacemesh/v1/types.proto

Lines 30 to 32 in 57864fb

    
           message SmesherId { 
        
               bytes id = 1; 
        
           }

Unify these. Should the ID be bytes or AccountId?

Note that we define SmesherID in go-spacemesh to be a NodeID: https://github.com/spacemeshos/go-spacemesh/blob/d4c11da68a0521ec8e23da1f3fd4a4a25c32de94/activation/activation.go#L76

which gets turned into an address: https://github.com/spacemeshos/go-spacemesh/blob/d4c11da68a0521ec8e23da1f3fd4a4a25c32de94/api/grpcserver/smesher_service.go#L114

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment