adds publicKey grpc endpoint #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm okay with this. @Narayanprusty @AmitShaul does it look good to you guys? |
web3rover
approved these changes
Jun 14, 2021
|
q: is the public key returned here different or same to smesher id in activations? |
|
@avive It should be the same. Unless I forgot everything about spacemesh in the last 20 days 😅 |
lrettig
requested changes
Jul 28, 2021
| @@ -13,4 +13,7 @@ service DebugService { | |||
| // This includes each account's address, nonce and balance but excludes projection of account state. | |||
| rpc Accounts (google.protobuf.Empty) returns (AccountsResponse); | |||
|
|
|||
| // PublicKey returns this node's public key | |||
There was a problem hiding this comment.
Could you expand this comment to explain exactly which public key is returned? go-spacemesh actually uses several public keys. See spacemeshos/go-spacemesh#2269 for more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for this myself when I came across #141.
If this looks good to everyone I could add it to go-spacemesh as well.
I was running into a weird issue when running
make build.It can't find the definition for
HttpRuleCloses #141