Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2pService #140

Open
lrettig opened this issue Mar 23, 2021 · 2 comments
Open

P2pService #140

lrettig opened this issue Mar 23, 2021 · 2 comments

Comments

@lrettig
Copy link
Member

lrettig commented Mar 23, 2021

It would be helpful to have a P2pService (or PeerService, or NetService) with features such as:

  • get the address book
  • get the current set of peer connections and the status of each (latency, time connected, IP/port, bytes in/out, etc.)
  • forcibly drop a peer or initiate a peer connection
  • change the target number of peer connections
@avive
Copy link
Contributor

avive commented Mar 23, 2021

Why not just add p2p functions to the NodeService? p2p is a node sub-components. We already have many services... It fits well in there especially since the Node service is designed to only be provided by a node that can be managed by the api client process. e.g. a local node managed via cliwallet, smapp or any other grpc client.

@lrettig
Copy link
Member Author

lrettig commented Mar 24, 2021

Yes, that could work too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants