Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confusion with the pop-out in FAQ #488

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix confusion with the pop-out in FAQ #488

wants to merge 12 commits into from

Conversation

GazdaN
Copy link
Collaborator

@GazdaN GazdaN commented Apr 2, 2024 •
edited
Loading

Description of the change

Tiny change to avoid confusion.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

@render Render
Copy link

render bot commented Apr 2, 2024

Your Render PR Server URL is https://spacelift-user-documentation-pr-488.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-co5v314f7o1s73aq1vv0.

@GazdaN GazdaN linked an issue Apr 2, 2024 that may be closed by this pull request
Change "this pop out" to "the same pop out" in the FAQ #479
Open
self-hosted-releases and others added 11 commits April 3, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change "this pop out" to "the same pop out" in the FAQ
4 participants
@GazdaN @damianstasik @tomasmik @adamconnelly